View Full Version : PATCH-fixes for span inconsistancies with screens
There were a few inconsistancies with the way colspan and rowspan were handled in both the screens configuation area and display in the frontend.
This sometimes caused tables to display with additional cells in relation to rowspan and rowspan combined with colspan. This patch should address that.
diffed against current 1.1beta1 which was the same as CVS at time of upload.
James Wells
04-11-2005, 06:28
Greetings.
Thanx Elkor, I have applied this patch to the CVS.
The patch was applied but produces warnings like "Variable spancheck is not defined". What is this patch about? What does it fix?
the existing funcitonality for spanning worked fine when columns were used, but when rows were to be spanned or a combination of the two there were issues where extra cells were added or the desired outcome was not acheived at all.
the spancheck variable was simply a placeholding array that the code checked to reference which cells were supposed to be skipped when building a table. I believe I corrected the issue with this particular error a few weeks ago but never posted the change :( , it was occuring because I referenced spancheck inside a loop where it was neither needed or defined. as soon as I get time I'll make the change (minor) against the current rev of the code and post the diff here for you.
sorry about that.