[1.3.8] Code errors in history.php

[JonB]

$severity = $row["severity"];

if($severity==0) $severity = S_NOT_CLASSIFIED;
elseif($severity==1) $severity = new CCol(S_INFORMATION,"information");
elseif($severity==2) $severity = new CCol(S_WARNING,"warrning");
elseif($severity==3) $severity = new CCol(S_AVERAGE,"average");
elseif($severity==4) $severity = new CCol(S_HIGH,"high");
elseif($severity==5) $severity = new CCol(S_DISASTER,"disaster");
elseif($severity==6) $severity = S_AUDIT_SUCCESS;
elseif($severity==7) $severity = S_AUDIT_FAILURE;
else $severity = $row["priority"];

$severity==6 and $severity==7 point to non declared variables S_AUDIT_SUCCESS and S_AUDIT_FAILURE. The two variables do not appear in the language files.

else $severity = $row["priority"]

should be

else $severity = $row["severity"]


And a slight spelling mistake 'warning' does not have two r's :)

Jon

[Alexei]

Thanks for reporting this! Will be fixed shortly.

[Alexei]

The problem is fixed in the latest SVN code.

[JonB]

Alexei,

Constants S_AUDIT_SUCCESS and S_AUDIT_FAILURE, history.php line 402 & 403 are still undeclared in the locales language files.

Jon

[Alexei]

Thanks for the followup! We added translation.