Ad Widget

Collapse

Unused global vars defined in line 43 of include/perm.inc.php, zabbix 1.4.2+

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • eli.stair
    Junior Member
    • May 2006
    • 20

    #1

    Unused global vars defined in line 43 of include/perm.inc.php, zabbix 1.4.2+

    I just noticed these PHP_AUTH_* vars which get defined globally but aren't referenced anywhere in the sources. Obviously not critical, just minor cruft...

    Cheers,

    /eli

    # no other instances existing:
    $ grep -c -r PHP_AUTH /usr/local/zabbix/php/* | grep -v :0
    /usr/local/zabbix/php/include/perm.inc.php:1


    # diff:

    --- php/include/perm.inc.php 2007-08-20 12:22:24.000000000 -0700
    +++ php/include/perm.inc.php 2007-10-31 15:55:28.000000000 -0700
    @@ -40,7 +40,6 @@
    function check_authorisation()
    {
    global $page;
    - global $PHP_AUTH_USER,$PHP_AUTH_PW;
    global $USER_DETAILS;
    global $_REQUEST;
    global $ZBX_LOCALNODEID;
Working...