Serious code issues

[geno]

Hi guys, I've tried support.zabbix.com and looked around for a more appropriate place to post this..

After being through the manual more than once, fiddling around with zabbix configuration for a few weeks, trolling/search/reading the forums all to no avail, I've decided to dig into the src code and the db structure to try and get answers.

I though I'd start with a src code compare between 1.6 and 1.6.1, and within a minute or so discovered the following (I've just copied two lines to illustrate the problem, this happened on almost all of the lines in this file, did someone loose their 'T' key?:p):

1.6:dbschema.c:1947
httpstepitemid bigint DEFAULT '0' NOT NULL,\
httpstepid bigint DEFAULT '0' NOT NULL,\

1.6.1:dbschema.c:1947
h ps epi emid bigin DEFAULT '0' NOT NULL,\
h ps epid bigin DEFAULT '0' NOT NULL,\



Not sure how this happens guys, but it would definately cause problems. Do you do code diffs before public release? QA cycle? :confused:
Now I'm really interested to see what the rest of the source looks like! Will post more later...

Anyways, I'm thinking of getting involved in the DEV side of Zabbix, really like this project, what do I do to join?

[troffasky]

Anyways, I'm thinking of getting involved in the DEV side of Zabbix, really like this project, what do I do to join?


Submit a patch? ;-)

[Alexei]

Please do more research first. The "Serious code issues" as you call it affects auto-creation of Sqlite database in Proxy based environment. This is already fixed, no need to create a patch.

[varrocs]

Hello,

I came across with this problem at auto-creating the Sqlite database. The 't' letters are substituted with a space. I checked the code of release 1.6.1 , but I've seen no sign of fixing this.

Maybe I ran over the it somewhere. In which version is that, or where can I find the patch.

Thaks,
Csaba

[Alexei]

The fix is not in 1.6.1 (well, it fixes this version), it will be out along with 1.6.2.