Zabbix 1.5.3 - Item Copy

[Palmertree]

Zabbix 1.5.3 - Item Copy

When an item is copied from one template to another, the message status shows that it was copied successfully but when you look at the items of the template you copied to it does not show up.

[Palmertree]

Strange problem. In items.inc.php line 304 is executed but really nothing happens when you go back and look at the template you copied the item key to even though the status screen said it was copied.

297
298 foreach($applications as $appid)
299 {
300 $itemappid=get_dbid("items_applications","itemappi d");
301 DBexecute("insert into items_applications (itemappid,itemid,applicationid) values($itemappid,".$itemid.",".$appid.")");
302 }
303
304 info("Added new item ".$host["host"].":$key");
305
306 // add items to child hosts

[Aly]

It's fixed

[Palmertree]

Thank you.....

I will download the most recent SVN and test and report back my findings...

[Niels]

Is this possibly related to https://support.zabbix.com/browse/ZBX-205 ?

[Aly]

Is this possibly related to https://support.zabbix.com/browse/ZBX-205 ?

No, it's not. It's related to 1.6 functionality only.

I will download the most recent SVN and test and report back my findings...

Be aware, profiles schema is changed!

[Palmertree]

What SQL value types should the following being for profiles for the newest SVN

value_id, value_int, value_str

value_id bigint 20
value_int ??
value_str ??

[Aly]

For now it's:

value_int INTEGER NOT NULL DEFAULT 0
value_str varchar(255) NOT NULL DEFAULT ''

P.S. You can compare create/schema/schema.sql file to previous..

[Palmertree]

For now it's:

value_int INTEGER NOT NULL DEFAULT 0
value_str varchar(255) NOT NULL DEFAULT ''

P.S. You can compare create/schema/schema.sql file to previous..

Sorry one more quick question, should value_int be "Unsigned"?

[Aly]

No, it shouldn't.

[Palmertree]

Thanks, Just realized that you said it is in the schema. Sorry about that.

[Aly]

You're welcome!

[Palmertree]

If there is one duplicate key in the list of items being copied, the entire copy is rolled back (DBend) even though items said that they were added successfully. Fixed this by posting true to DBend. Also, I wonder if "Delete" and "Update" will have the same problem.

Before:

466                         DBstart();
467                         foreach($_REQUEST["group_itemid"] as $item_id)
468                                 foreach($hosts_ids as $host_id){
469                                         $result &= copy_item_to_host($item_id, $host_id, true);
470                                 }
471
472                         [COLOR="Red"]$result = DBend($result);[/COLOR]
473                         show_messages($result, S_ITEMS_COPIED, S_CANNOT_COPY_ITEMS);
474                         unset($_REQUEST["form_copy_to"]);

After:

466                         DBstart();
467                         foreach($_REQUEST["group_itemid"] as $item_id)
468                                 foreach($hosts_ids as $host_id){
469                                         $result &= copy_item_to_host($item_id, $host_id, true);
470                                 }
471
472                         [COLOR="Red"]$result = DBend(true);[/COLOR]
473                         show_messages($result, S_ITEMS_COPIED, S_CANNOT_COPY_ITEMS);
474                         unset($_REQUEST["form_copy_to"]);

[Aly]

We've changed the logic in situations like that.. now it will be committed if at least one item copied successfully.