Version Pre 1.7.0 Build 7125 -- New Multi Select Groups

[Palmertree]

When adding host_groups to a user_group using the new multi select feature, the select button will not work if host_groups are selected. If nothing is selected the popup_rights window will disappear if the "select" button is clicked. Buf if at least one host_group is selected to be added, the "select" button does not do anything.

[Palmertree]

Is anyone else seeing this issue or is it a problem on my end? Thanks in advance.

[richlv]

it was a bit hard to decypher which screen you are talking about - this is about permissions.
adding access to hostgroups for a usergroup indeed doesn't work - confirming the problem in trunk, revision 7130

[Aly]

Hmm I don't see any problems with adding host_groups to RW/ RO/ DENY must be looking in wrong place?!

[richlv]

administration -> users -> user groups
click on any group name, click on 'add' below any of the rw/ro/deny blocks.
mark at least two groups, click on 'select' - nothing happens.

trying with opera 9.64 here

[richlv]

ok, this is fishy. it looks like _created_ groups through the ui can't be added. default ones can. so try this with a group that you have just created.

[Aly]

Created new user group and new host group, added new Host group to RO column.. still can't find any problem (Opera 9.63)

[richlv]

ok, did some more testing. it looks like something's wrong with ids - for those groups that i can add, incorrect group is actually added.
for example, if i try to add group with id 6 - nothing happens.
if i try to add group with id5, group id4 is added, 4->3, 3->1, 2->5, 1->2.

i don't see a pattern here. it's not off by one, it's not taking alphabetical order...

[Palmertree]

Strange, I can not getting any group host to be selected and added to eiter RW / RO / D. I'll do some more testing to see if I can figure out any sort of pattern.

[Palmertree]

richlv thanks for testing. When you do see the problem, when you click the "select" button does it seems like it does nothing and the popup_rights window stays on the screen?

[richlv]

yes, but this only seems to happen with the last group i have added - as i said, selecting other groups adds some other group.
i'm not sure about 'popup_rights" reference, group selection popup window has title "Resource"

[Palmertree]

Using "Firebug" I am getting grouplist[e.value] is undefined in line 74. Not sure if this helps or not. I am still debugging to see if I can find anything.

	$('groups').getInputs("checkbox").each(  72		function(e){
 73			if(e.checked && (e.name != "all_groups")){
 74				add_variable('input', 'new_right['+e.value+'][permission]', grouplist[e.value].permission, formname, parent_document);
 75				add_variable('input', 'new_right['+e.value+'][name]', grouplist[e.value].name, formname, parent_document);
 76			}
 77		});

[richlv]

that seems to be close. i got an idea to take a look at opera's error console

Event thread: click
Error:
name: TypeError
message: Statement on line 11: Cannot convert undefined or null to Object
Backtrace:
Line 11 of inline#2 script in http://10.196.5.14/zabbix/popup_righ...p&permission=2
add_variable('input', 'new_right['+e.value+'][permission]', grouplist[e.value].permission, formname, parent_document);
... Line 603 of linked script http://10.196.5.14/zabbix/js/prototype.js
iterator.call(context, value, index++);
... Line 602 of linked script http://10.196.5.14/zabbix/js/prototype.js
this._each(function(value) {
Line 8 of inline#2 script in http://10.196.5.14/zabbix/popup_righ...&permission=2: In function add_groups
$('groups').getInputs("checkbox").each(
Line 1 of function script
add_groups("web.users.groups.php")
...

[Aly]

I've been testing it on DM, but problem related only to non DM setup

Fixed. rev. 7152

BTW: problem is related to PHP arrays..

[Palmertree]

Thanks Aly for the quick fix. I will try and be more descriptive in my problems next time to make it easier. I will test and let you know. Thanks again and thanks richlv for your input as well.