trunk, 7250: eventview errors

[richlv]

opening monitoring -> events shows an error message (which could be because no events were found) :

max(): Array must contain at least one element[/srv/www/htdocs/zabbix-1.7/events.php:343]
Undefined offset: 0[/srv/www/htdocs/zabbix-1.7/include/config.inc.php:1283]
array_multisort(): Argument #1 is expected to be an array or a sort flag[/srv/www/htdocs/zabbix-1.7/include/config.inc.php:1295]

changing the date in the filter produces another error (once per event found) :

Undefined index: e.clock[/srv/www/htdocs/zabbix-1.7/include/config.inc.php:1290]

[richlv]

for the record, same/similar errors are shown in action audit as well with slight changes in variable names, like :

Undefined index: a.clock[/srv/www/htdocs/zabbix-1.7/include/config.inc.php:1290]

[richlv]

...and the problems seem to be resolved by revision 7271

[Aly]

...and the problems seem to be resolved by revision 7271

I hope so

What do you think about new events, audit view?

[richlv]

heh. well, several quick observations

1. event filter is missing time fileds. while calendar popup provides those, entered values are discarded;

2. from usability point of view, previous design with from/to and latest entries displayed at top seemed a bit more intuitive (note, that might be heavily influenced by me simply getting used to it). one benefit of the old design - things most users would be most interested in, latest entries - were always visible by default. now new entries are at the bottom of the list, and i have to set a starting date, so if latest entry for a particular trigger or recipient was an unknown time ago, i have to guess or know the approximate date. if i do not know that, i have to poke around the interface until i find acceptable value.

from my minimal tests, it seems that the new design always requires more clicks to get to the data, and i was quite surprised when i opened it to see no data. turns out, i have to open filter and enter some earlier data, as my test system had no events at that particular day.

on the other hand, if i had a ton of events and actions, both logs do not provide from-to filter, thus i might again have to guess a starting period that allows me easy access to the interesting entries.

maybe i'm simply using it in an incorrect way ?

[Aly]

I see.. I'll take a look at what I can do here.

[Aly]

Will it fit if events history would show:
1. If start time is not set, the latest events at top (timeline: now -> past);
2. If start date is set, then we show events starting from chosen date (timeline: past -> now).

?

[richlv]

i'm no ui expert - but i would strongly suggest avoiding sort order change - in any screens.
personally i feel that newer events at top (everywhere !) would be more usable.
if, for some reasons, it is decided the opposite, it should be opposite _everywhere_ and should not change.

humans are very good at developing habits, and flipping the order works heavily against that.

with "everywhere" i mean audit (logs, actions), event view, events in dashboard... everywhere.
as i said, i feel that newer events at top seems a better idea to me because of the reasons i tried to detail before. i'm not saying it is impossible to make the opposite work as well or better, but i can't envision a model that would work well

[Aly]

You can sort events by clicking on "time"..

[richlv]

sure. i was assuming we are talking about default ordering and locations that can't be sorted (like last 20 issues in dashboard)