PATCH: graph font scaling and graph title misalignment

[krimson]

This patch fixes a few things in Zabbix 1.8 (& trunk)

* misaligned graph title on smaller graphs (title was not centered) [ZBX-1320]
* for smaller graphs, the font sizes were not scaled accordingly, causing text to fall off
* Y axis type is displayed vertically to save space
* less "whitespace" on small graphs to make them more compact

I have attached two examples of how it looks now. Patch can be applied to Zabbix trunk (and possibly to 1.8, not tested).

UPDATED: Also attached a patch for Zabbix 2.0.3.

[Palmertree]

Krimson, nice patch. It works great against the latest 1.8 trunk 9330. Thanks for sharing this.

[dotneft]

exellent patch, thanks. But thise patch not resize triggers text((

[Palmertree]

Fixed the triggers by modifying the same file at the following lines:

@@ -1505,7 +1507,7 @@
                        );
                $legend->color = $this->getColor($this->graphtheme['textcolor'], 0);
                $legend->rowheight = 14;
-               $legend->fontsize = 9;
+               $legend->fontsize = $this->baseFontSize+1;

 // Draw percentile
                if($this->type == GRAPH_TYPE_NORMAL){
@@ -1558,7 +1560,7 @@
                        );
                $legend->color = $this->getColor($this->graphtheme['textcolor'], 0);
                $legend->rowheight = 14;
-               $legend->fontsize = 9;
+               $legend->fontsize = $this->baseFontSize+1;

 // Draw triggers
 //SDII($this->triggers);

[Firm]

Confirmed patch working even with initial 1.8 release.

P.S. Krimson, would you be so kind to fix this issue too? On attached graph some digits of Y-axis values are out of graph edge.

[krimson]

Oops, can't believe I missed the trigger text

Fixed that, and also "fixed" the Y-axis text. See screenshot for how it looks now. I have updated my original post with the actual patch and screenshots.

[Firm]

Krimson,

Good work! Patched successfully against latest rev9421 from svn. But there's one bug has been appeared. Units' name is now rotated and moved from the label on Y-axis.

[krimson]

It is supposed to show the itemtype only once now on the Y axis to save space. I updated the patch so it leaves a little more space for larger graphs and fontsize. Give it a try

[Firm]

krimson,

Graphs are displayed fine now. Thanks, man!

[Firm]

Patch works against Zabbix 1.8.1 (released today).

[krimson]

Good stuff

[bogus]

Krimson, great patch. Did you update the patch maybe to work with 1.8.2?

[fjrial]

tested and working with 1.8.2

Just tested with 1.8.2 and it works..

but you can't apply the patch, because line numbers have changed. You'll have to overwrite lines by searching and replacing (or at least, this is how I did it, because I don't know other way to do it).

thanks for this wonderful patch.

[krimson]

Here's a patch for Zabbix 1.8.3 Give it a try.

[Pada]

updated patch for v1.8.11+

Thank you very much for that patch!

I wasn't able to apply that patch with the patch application since too much has changed since 1.8.3 & 1.8.11.

I have modified the patch a bit so that it works on 1.8.11 and I've just tried it on 1.8.13 and it was successful too.

There are certain areas that I've not been able to completely update, and I've marked those parts in the patches with "Patch partially applied" or "Patch not applied due to new code".

I have also decreased the base font size from 8 to 7 in my version of the patch.

Off-Topic:
I've also submitted a patch that allows you to set limits separately for the left & right Y-axis: https://support.zabbix.com/browse/ZBXNEXT-245