PATCH: variable {ITEM.NAME} for alert messages

[just2blue4u]

I made a patch providing the variable {ITEM.NAME}.
It contains the description of the triggering item. Example:

Item:
- Description: Performance SMTP-Server (0=offline)
- Key: smtp_perf<25>

Trigger:
- Name: "Keine Verbindung zum Mailserver @ {HOSTNAME} möglich"
- Expression: {tmpl_ux:smtp_perf<25>.avg(120)}=0

Action message:

Betroffenes System: {HOSTNAME} (IP = {IPADDRESS})
Komponente: {ITEM.NAME} ({TRIGGER.KEY}) = {{HOSTNAME}:{TRIGGER.KEY}.last(0)}

=============================================================
Es erfolgt eine Entwarnung, sobald das Problem behoben ist...

received eMail:

Betroffenes System: mail-2.bfk (IP = *UNKNOWN*)
Komponente: Performance SMTP-Server (0=offline) (smtp_perf<25>) = 0 ms

=============================================================
Es erfolgt eine Entwarnung, sobald das Problem behoben ist...

Patched file: src/zabbix_server/expression.c
Server version: 1.1.3
diff command: diff src/zabbix_server/expression.c.orig src/zabbix_server/expression.c > expression.c.diff

I tested this patch with ./configure, make, make install and it works for me.

WARNING: This is the first time i modified parts of foreign C source and created a patch. So please let me know if there is something that i did wrong!

The attached file is a diff, so just rename it to "expression.c.diff" (remove ".txt")

Maybe, if this patch is ok, i could create more like this...

[dsipe]

does your patch work for trigger name ?

I mean is it possible to create a trigger with the name "{ITEM.NAME}" ?

[just2blue4u]

No, i just tested it and it doesn't work.

I'll try to add this, too...

[James Wells]

Greetings,

Thanx for the great feature. I have taken it and extended it a bit more to support a need we have where I work. Currently, we have about 22000 items and 15000 triggers. With this many, it is often difficult to keep track of what each trigger means and how best to support it. To fix this, we have taken your patch and added another macro {TRIGGER.COMMENT}, which will pull the comment from an alerting trigger and add it to the message.

Rather than post a diff against yours, I simply re-packaged yours with mine tacked on afterwards.

[Alexei]

FYI: TRIGGER.COMMENT and TRIGGER.URL are already in pre 1.1.5. I think I mentioned this in some other thread.

ITEM.NAME is not implemented yet.

[Alexei]

Support of {ITEM.NAME} has been implemented as well.

[just2blue4u]

thanks, alexei!

Zabbix roxx! *thumbs up*