cpuinfo: iowait, irq, softirq, steal

[adam.vollrath]

patch updated for current trunk

This patch worked against 1.5.3 for me. I also recommend integrating it into the trunk for 1.5.4.

I've also opened a Zabbix support center ticket regarding this, ZBX-383 I think.

[Wouaf]

Hi,

Can you tell us if this code was integrated in 1.6 version

Thanks

[lamont]

porting this patch to 1.4.6 and found this which i think is a bug in the patch:

+ CALC_CPU_LOAD(irq, 1);
+ CALC_CPU_LOAD(irq, 5);
+ CALC_CPU_LOAD(irq, 15);
+
+ CALC_CPU_LOAD(softirq, 1);
+ CALC_CPU_LOAD(softirq, 5);
+ CALC_CPU_LOAD(softirq, 15);
+
+ CALC_CPU_LOAD(irq, 1);
+ CALC_CPU_LOAD(irq, 5);
+ CALC_CPU_LOAD(irq, 15);

i think the last 3 lines in the patch there should be s/irq/steal/

[lamont]

port to 1.4.6

here's a port to 1.4.6

- no guarantees
- compiles
- i tested on one box and got sane values for user/sys/nice/idle/iowait

- not sure about how i handled sys/pstat.h since i don't have that on RHEL:
-- added CP_INTR for irq (not sure if this should be irq or softirq or both)
-- set other values to zero (not sure if that is the right idea either)
-- don't know if there are pstat.h linux versions out there that support iowait or other values because i could only find BSD versions of pstat.h on google
( all that shouldn't affect anyone that has /proc/stat instead of /usr/include/sys/pstat.h, which i think is the vast majority of linux use cases )

[noxis]

Not having this is in Zabbix 1.6 is a show stopper for us preventing us from upgrading.

[drose12]

Any update on 1.6.x status?

[verwilst]

Also looking for this feature...

[ataylo13]

This would be a nice addition to 1.6.x

[Alexei]

It is very likely this will be supported by 1.6.3!

[ataylo13]

Very nice Alexei!

[simix]

One has to keep in mind that those patches don't work with older Linux kernel IIRC. Maybe it should be added with a check for the kernel version, as it is also the case in other parts of Zabbix.

[bbrendon]

https://support.zabbix.com/browse/ZBX-26

Am I seeing things? I think someone hacked the zabbix ticket system. This can't be!

[Alexei]

It was implemented. Please wait for official 1.6.3!

[bbrendon]

It was implemented. Please wait for official 1.6.3!

Wait? Are you insane? Now I have a good reason to update agents. I still have 1.4 agents out there because (to me anyway) there hasn't been a reason to upgrade. I wonder how many system.run items I'll eliminate with these new features. I'll be honest, I have a gripe that WAY too many custom items are necessary to collect performance metrics. I use very little of what the agent does because it's too generic.

[Alexei]

I'll be honest, I have a gripe that WAY too many custom items are necessary to collect performance metrics. I use very little of what the agent does because it's too generic.

It would be interesting to know what metrics could be also integrated into the agent. By the way, I am sure you are already aware of this, you may take advantage of the 'Include' statement in zabbix_agentd.conf to manage user parameter in a more structured way. It works under 1.6.x though.