Ad Widget

Collapse

cpuinfo: iowait, irq, softirq, steal

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Int
    Junior Member
    • Oct 2005
    • 7

    #1

    cpuinfo: iowait, irq, softirq, steal

    Quick patch to make zabbix_agentd known about extended cpu stats
    please comment

    PS: Linux only
    Attached Files
  • bbrendon
    Senior Member
    • Sep 2005
    • 870

    #2
    Seems like a reasonable patch to include in upstream.
    Those stats are very important for performance analysis. Zabbix agents out of the box don't collect enough info to troubleshoot performance.
    Unofficial Zabbix Expert
    Blog, Corporate Site

    Comment

    • SharkCZ
      Member
      • Apr 2006
      • 39

      #3
      Yes, these values are really important. I have updated the patch for 1.4.2.

      Edit: patch updated 19.9.2007
      Attached Files
      Last edited by SharkCZ; 19-09-2007, 12:00.

      Comment

      • SharkCZ
        Member
        • Apr 2006
        • 39

        #4
        Originally posted by SharkCZ
        Yes, these values are really important. I have updated the patch for 1.4.2.
        Not only are these numbers important, but the current state can be considered buggy (at least for Linux). For example on a system with IDE disks the iowait state can take tens of percent.

        Comment

        • noxis
          Senior Member
          • Aug 2007
          • 145

          #5
          This is a fantastic patch, we run large clusters of servers (ISP) for different uses (web,mail, mysql etc etc). IOWAIT is one of the BIGGEST factors we need to know when things slow down. To date (out of the box) only munin would graph this.

          Alexei: Please PLEASE add this into the next version.

          Comment

          • Alexei
            Founder, CEO
            Zabbix Certified Trainer
            Zabbix Certified SpecialistZabbix Certified Professional
            • Sep 2004
            • 5654

            #6
            It is already in our TODO list
            Alexei Vladishev
            Creator of Zabbix, Product manager
            New York | Tokyo | Riga
            My Twitter

            Comment

            • noxis
              Senior Member
              • Aug 2007
              • 145

              #7
              Is this in 1.4.3/4 or is a new patch required? Cheers

              Comment

              • SharkCZ
                Member
                • Apr 2006
                • 39

                #8
                Originally posted by noxis
                Is this in 1.4.3/4 or is a new patch required? Cheers
                The patch is not integrated yet and can be applied without modification.

                Comment

                • bbrendon
                  Senior Member
                  • Sep 2005
                  • 870

                  #9
                  Any update? Has this been included? Whats the holdup??
                  Unofficial Zabbix Expert
                  Blog, Corporate Site

                  Comment

                  • maxpower
                    Member
                    • Jul 2007
                    • 31

                    #10
                    Same question here. Obviously the agent still doesn't report cpu idle times in 1.4.5 (at least for Solaris).

                    Comment

                    • maxpower
                      Member
                      • Jul 2007
                      • 31

                      #11
                      Bug found

                      Again a "bug" in configure.

                      While /proc/loadavg and others might exist on one Solaris machine it could not exist on another but the behaviour is fixed in Zabbix cpu.c (ifdef HAVE_PROC_LOADAVG ...). Please determine the existence of this file dynamically and not at compile time !
                      It will not report any cpu data because of this.

                      Comment

                      • maxpower
                        Member
                        • Jul 2007
                        • 31

                        #12
                        cpu.c broken for solaris

                        Originally posted by maxpower
                        Again a "bug" in configure.

                        While /proc/loadavg and others might exist on one ...
                        You don't even have to look at this file ! Just call getloadavg as you did in earlier versions. The exsistence of /proc/loadavg is no precondition for this function to work !
                        Please remove all #ifdef HAVE_PROC_LOADAVG calls from cpu.c.

                        Comment

                        • SharkCZ
                          Member
                          • Apr 2006
                          • 39

                          #13
                          patch updated for current trunk
                          Attached Files

                          Comment

                          • maxpower
                            Member
                            • Jul 2007
                            • 31

                            #14
                            Sorry, i tried your patch for zabbix_agent cpustat.[ch] and still i get "not supported" for idle,user,etc.
                            I didn't apply your Linux patch because i monitor Solaris.

                            Comment

                            • bbrendon
                              Senior Member
                              • Sep 2005
                              • 870

                              #15
                              Alexei & Crew-
                              Can you add this to your code?
                              Unofficial Zabbix Expert
                              Blog, Corporate Site

                              Comment

                              Working...