Items: key length

[spike]

Hi.
I used 1.1beta9 version of Zabbix to monitor windows servers using Performance Counters and at one moment I discovered that hardcoded maximum key length (64 bytes) for items is not enough.
Unfortunately this limit appears in few places - database and few times in the source code. I spent some time fixing sources and debuging and finally had got it working.

Also Zabbix Agent/win32 has problems with some characters sometimes found in performance counter names (# AFAIR, but I might be wrong).

Now I've got 1.1.1 - thank you guys for this great work. And unfortunately I have to increase that limit again by digging the source code.

Could you increase that limit in Zabbix source code?
I believe I am not only one facing need in higher maximum key length.

[crashdummyMCH]

key length problem

I too am experiencing the key length problem. Especially when monitoring files that have long paths. This i think really need to get addressed soon. It is still a problem in the 1.1.1 source.

Thanks zabbix team.

[Alexei]

The issue will be addressed by 1.1.2.

[dave smith]

When will 1.1.2 be released? I think it's really cool, and can't wait till I can do more math expressions in the 'items' monitoring area.

[schneck]

Rsn

When will 1.1.2 be released? I think it's really cool, and can't wait till I can do more math expressions in the 'items' monitoring area.

For some answers by someone who should know, see http://www.zabbix.com/forum/showpost...28&postcount=4

[sbadger]

How long was the item field extended to? I didn't see any thing in the change log about it.

[peter_field]

How can this be changed if no database patch is required?

From

http://www.zabbix.com/forum/showthread.php?p=13646#post13646

Upgrade
In order to upgrade from previous releases, no execution of
database patches required. See Upgrade Guide
http://www.zabbix.com/manual/v1.1/config_upgrading.php for
full details on upgrade procedure.

So does this mean the code limitations are addressed, but we manually have to change the database limit, and if so, like sbadger has brought up, what is the limit now?

[peter_field]

Still an issue in 1.1.2?

I have just had a look through the 1.1.2 code, and it appears this limit is still in the code (see below). I only had a quick look, and haven't tested changing it at all.

My questions are:
- Is list right? Anyone know of other locations?
- If we simply change the constant and recompile will everything work well?
- Should this be documented somewhere so people can easily change it, or should it simply be set to a higher value in the release code?

/include/db.h
#define MAX_ITEM_KEY_LEN 64
#define ITEM_KEY_LEN 64
#define ITEM_KEY_LEN_MAX ITEM_KEY_LEN+1

it only appears to be used here:
/src/zabbix_server/actions.c, line 253
snprintf(item.key,ITEM_KEY_LEN_MAX-1,"system.run[%s,nowait]",command);

Regards,

Peter