1.4: oracle support + suggestion
Hi,
I try to use Oracle with latest SVN, but there is a lot of bugs.
* in gen.pl, the "t_double" => number(20,4) line is not good: should be t_double => number , because the presision is in schema.sql
* in gen.pl, the "t_time" is missing : should be t_time => number(10)
* in schema.sql, the default value '' and the NOT NULL attribute fail with oracle : the NOT NULL should be removed
* in schema.sql, some default value should be updated like the field "details" in auditlog table ( default value 0 for a text field ??)
* in schema.sql, the hosts.ip field can be null with template: --> remove the NOT NULL attribute
* in schema.sql, the items.formula field can be null : --> remove the NOT NULL attribute
* in data.sql, the < and > should be replaced by < and > for oracle
* in C code:
- src/libs/zbxdb/db.c in zbx_db_connect,
==> there is exit(FAIL) and not ret = ZBX_DB_FAIL instruction.
==> the line printf ("Cannot login with %s\n", connect) is not necessery.
- i found some HAVE_ZZZ in source ?????
* in PHP code:
==> include/db.inc.php line 62: the last parameter $DB_DATABASE is missing in ocilogon
line 455: it's necessery to use the round function with oracle otherwise the correct nodeid is not found. But i don't test with Distributed node and i don't understand why a div is used to get the nodeid.
==> if DNS is left blank for a host, there is a missing cell in hosts.php view. but i don't find why.
Even if a host is monitored, there is no data collected by zabbix, but i see no error in log file. With postgresql, it's works.
now, some suggestion / question :
* the SNMP info (community, user and password for snmpv3) is host or entrprise level settings, and should not be in items table. This value are the same for all SNMP items of a host.
* Why don't you keep database connection open ? The connection process is an expensive task for database.
* Is there any info concerning maintener for database code or translation file?
* Could you have a more strict release process ? For example, in the last release 1.4, the build for postgresql is broken but works in 1.3.8. It's harm for the quality of your works.
Thanks
Franck
I try to use Oracle with latest SVN, but there is a lot of bugs.
* in gen.pl, the "t_double" => number(20,4) line is not good: should be t_double => number , because the presision is in schema.sql
* in gen.pl, the "t_time" is missing : should be t_time => number(10)
* in schema.sql, the default value '' and the NOT NULL attribute fail with oracle : the NOT NULL should be removed
* in schema.sql, some default value should be updated like the field "details" in auditlog table ( default value 0 for a text field ??)
* in schema.sql, the hosts.ip field can be null with template: --> remove the NOT NULL attribute
* in schema.sql, the items.formula field can be null : --> remove the NOT NULL attribute
* in data.sql, the < and > should be replaced by < and > for oracle
* in C code:
- src/libs/zbxdb/db.c in zbx_db_connect,
==> there is exit(FAIL) and not ret = ZBX_DB_FAIL instruction.
==> the line printf ("Cannot login with %s\n", connect) is not necessery.
- i found some HAVE_ZZZ in source ?????
* in PHP code:
==> include/db.inc.php line 62: the last parameter $DB_DATABASE is missing in ocilogon
line 455: it's necessery to use the round function with oracle otherwise the correct nodeid is not found. But i don't test with Distributed node and i don't understand why a div is used to get the nodeid.
==> if DNS is left blank for a host, there is a missing cell in hosts.php view. but i don't find why.
Even if a host is monitored, there is no data collected by zabbix, but i see no error in log file. With postgresql, it's works.
now, some suggestion / question :
* the SNMP info (community, user and password for snmpv3) is host or entrprise level settings, and should not be in items table. This value are the same for all SNMP items of a host.
* Why don't you keep database connection open ? The connection process is an expensive task for database.
* Is there any info concerning maintener for database code or translation file?
* Could you have a more strict release process ? For example, in the last release 1.4, the build for postgresql is broken but works in 1.3.8. It's harm for the quality of your works.
Thanks
Franck
Comment