zabbix1.6.1 triggers expression memory leak?

[k-ren]

Hi Alexei
On zabbix1.6.1.
When much "Division by zero" happens on trigger expression very minute,the zabbix_server process will eat memory.Is it a bug?

######ps result################
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
4020 zabbix 21 5 15736 7524 980 S 8 0.2 9:07.18 zabbix_server
4016 zabbix 21 5 11776 2708 1756 S 1 0.1 4:19.78 zabbix_server
4028 zabbix 20 5 18352 9652 980 S 1 0.2 9:09.37 zabbix_server
4014 zabbix 21 5 12920 3672 1756 S 0 0.1 4:29.10 zabbix_server
4015 zabbix 22 5 11776 2708 1756 S 0 0.1 4:14.36 zabbix_server
4013 zabbix 22 5 8428 1392 948 S 0 0.0 0:00.51 zabbix_server
4017 zabbix 22 5 11772 2700 1756 S 0 0.1 4:18.03 zabbix_server
4018 zabbix 21 5 12992 3736 1756 S 0 0.1 4:28.86 zabbix_server
4019 zabbix 21 5 21144 11m 980 S 0 0.3 9:09.66 zabbix_server
4025 zabbix 20 5 14684 6760 980 S 0 0.2 9:22.06 zabbix_server
4027 zabbix 20 5 17776 9220 980 S 0 0.2 9:07.50 zabbix_server
4029 zabbix 23 5 8428 1064 624 S 0 0.0 0:00.43 zabbix_server
4030 zabbix 22 5 8428 1040 600 S 0 0.0 0:00.24 zabbix_server
4031 zabbix 21 5 8428 1192 676 S 0 0.0 1:00.45 zabbix_server
4032 zabbix 21 5 62812 45m 916 S 0 1.2 49:21.77 zabbix_server
4033 zabbix 20 5 11672 2260 1368 S 0 0.1 0:01.79 zabbix_server
4035 zabbix 20 5 8428 1040 600 S 0 0.0 0:02.44 zabbix_server
4036 zabbix 20 5 8428 1044 604 S 0 0.0 0:01.94 zabbix_server
4039 zabbix 20 5 8428 1044 604 S 0 0.0 0:01.97 zabbix_server
4040 zabbix 20 5 8428 1044 604 S 0 0.0 0:01.93 zabbix_server
4073 zabbix 20 5 8428 1044 604 S 0 0.0 0:02.07 zabbix_server
4074 zabbix 20 5 8428 1044 604 S 0 0.0 0:01.92 zabbix_server
4075 zabbix 20 5 11672 2252 1360 S 0 0.1 0:00.07 zabbix_server
4076 zabbix 20 5 8428 1064 624 S 0 0.0 0:02.26 zabbix_server

#####zabbix server log#############
4032:20090106:102217 Expression [(({29585}/{29584})>1.4)&({29583}>065959)&({29583}<220000)] for item [23010][server1072_TrafficriginatingCompleteCallNumber] cannot be
evaluated: Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29588}/{29587})<0.4)&({29586}>215959)] for item [23010][server1072_TrafficriginatingCompleteCallNumber] cannot be evaluated: Divis
ion by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29591}/{29590})>1.6)&({29589}>215959)] for item [23010][server1072_TrafficriginatingCompleteCallNumber] cannot be evaluated: Divis
ion by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29570}/{29569})<0.6)&({29568}>065959)&({29568}<220000)] for item [23006][server1072_Traffic:rgwDestineTotalCallNumber] cannot be eva
luated: Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29573}/{29572})>1.4)&({29571}>065959)&({29571}<220000)] for item [23006][server1072_Traffic:rgwDestineTotalCallNumber] cannot be eva
luated: Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29576}/{29575})<0.4)&({29574}>215959)] for item [23006][server1072_Traffic:rgwDestineTotalCallNumber] cannot be evaluated: Division
by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29579}/{29578})>1.6)&({29577}>215959)] for item [23006][server1072_Traffic:rgwDestineTotalCallNumber] cannot be evaluated: Division
by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29570}/{29569})<0.6)&({29568}>065959)&({29568}<220000)] for item [23007][server1072_Traffic:rgwDstCompleteCallNumber] cannot be eval
uated: Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29573}/{29572})>1.4)&({29571}>065959)&({29571}<220000)] for item [23007][server1072_Traffic:rgwDstCompleteCallNumber] cannot be eval
uated: Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29576}/{29575})<0.4)&({29574}>215959)] for item [23007][server1072_Traffic:rgwDstCompleteCallNumber] cannot be evaluated: Division b
y zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29579}/{29578})>1.6)&({29577}>215959)] for item [23007][server1072_Traffic:rgwDstCompleteCallNumber] cannot be evaluated: Division b
y zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29558}/{29557})<0.6)&({29556}>065959)&({29556}<220000)] for item [23004][server1072_Traffic:rgwOrgCompleteCallNumber] cannot be eval
uated: Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29561}/{29560})>1.4)&({29559}>065959)&({29559}<220000)] for item [23004][server1072_Traffic:rgwOrgCompleteCallNumber] cannot be eval
uated: Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Expression [(({29564}/{29563})<0.4)&({29562}>215959)] for item [23004][server1072_Traffic:rgwOrgCompleteCallNumber] cannot be evaluated: Division b
y zero. Cannot evaluate expression [0/0]
4032:20090106:102217 Division by zero. Cannot evaluate expression [0/0]
................

[k-ren]

I just make a test.
When change the code of expression.c,it will be OK(the memory usage of zabbix process will not grow).
What is the reason?

/root/zabbix-1.6.1/src/libs/zbxserver/expression.c
■expression.c
############
　　　　　if(cmp_double(value2,0) == 0)
{
zbx_snprintf(error,maxerrlen,"Division by zero. Cannot evaluate expression [%s/%s]",
first,
second);
zabbix_log(LOG_LEVEL_WARNING, "%s",
error);
zabbix_syslog("%s",
error);
return FAIL;
}
else
{
*result=value1/value2;
}
return SUCCEED;
....

############

■expression.c(changed for test)
############
....
　　　　　if(cmp_double(value2,0) == 0)
{
*result=1;
return SUCCEED;
}
else
{
*result=value1/value2;
}
return SUCCEED;
....
############