1.4 Node Watcher Thread

[NOB]

Hi,

if you just have one masternode with the id 0 - as you seem to have,
there is an endless-loop in the code.
The following patch fixes it - applied to 1.3.7 and 1.3.8.

--- zabbix-1.4/src/zabbix_server/nodewatcher/nodesender.c       Tue May 29 14:52:49 2007
+++ zabbix-1.3.8/src/zabbix_server/nodewatcher/nodesender.c     Tue May 22 15:02:23 2007
@@ -388,8 +388,8 @@
 
        send_to_master_and_slave(nodeid);
 
-       result = DBselect("select nodeid from nodes where masterid=%d",
-               nodeid);
+       result = DBselect("select nodeid from nodes where masterid=%d and nodeid != %d",
+               nodeid, nodeid);
        while((row=DBfetch(result)))
        {
                process_node(atoi(row[0]));

No surprise, that the memory gets allocated that fast.
It's "just" the stack that grows.

We are not running 1.4 server for now. Just waiting for 1.4.1 and
testing the agents of 1.4.

HTH,

Norbert.

[agehring]

That patch fixed the problem.

I had setup zabbix to run with the libgmalloc, but after doing that it no longer failed.

All of the backtraces I had run against the failed instances had pointed to nodesender.

As a added benefit, the system isn't running at such a breakneck pace anymore either.

Thanks Norbert!
Andrew

[Alexei]

Note that installation of ZABBIX 1.4 does not create any records in table 'nodes'! The record with NodeId=0 seems suspicious to me.

[agehring]

Do you believe removing the DB entry would alleviate the issue?

Thanks,
Andrew

[Alexei]

Yes, it is absolutely safe to remove this entry!

[NOB]

Hi,

OK, why I have this entry in the "nodes" table:

As soon as you start zabbix_server -n 0 this node is created in the
DB.
After that I was immediately hit by the above problem.
That's why I fixed it.

So, what is a good idea for the "real" master node, i.e. the root
of the tree ?
0 obviously isn't :-)

Regards,

Norbert.