Events page is not working

[alj]

half of page shows up, for enother half of page i see
Undefined variable: rclock[/usr/share/zabbix/include/events.inc.php:204]

1.4.2 version.

[alj]

Fix

while($rows = DBfetch($res)){
$rclock = $rows['clock'];
}
if($rclock != $row['clock']) return false;

changed to:

$rclock=0;
while($rows = DBfetch($res)){
$rclock = $rows['clock'];
}
if($rclock != $row['clock']) return false;

[Aly]

It's strange that you get that warning.. you really shouldn't by the logic.
Could you show event history of that trigger(where warning occurs)..

[alj]

It's strange that you get that warning.. you really shouldn't by the logic.
Could you show event history of that trigger(where warning occurs)..

I cant. There was half of page filled with errors i posted above. When i put that line into source, that half of page disappeared.

[alj]

It's strange that you get that warning.. you really shouldn't by the logic.
Could you show event history of that trigger(where warning occurs)..

Why do you think is strange? if $rlock was defined within {} scope it doesnt exist after }, right? I didnt see any definition of $rlock anywhere earlier in the script. Or php5 doesnt have meaning of variable scope?

[alj]

It's strange that you get that warning.. you really shouldn't by the logic.
Could you show event history of that trigger(where warning occurs)..

Another thing - if DBfetch($res) returns with 0 right away rlock will never receive any value, right?

This is very confusing, i can hardly understand whats going on by looking at the source ;-))

[Aly]

Why do you think is strange? if $rlock was defined within {} scope it doesnt exist after }, right? I didnt see any definition of $rlock anywhere earlier in the script. Or php5 doesnt have meaning of variable scope?

There is var. scope, but it's not like in C or Java. $rclock will exist after }.

You get errors because in some situation script in second DBfetch($res) returns false. But you get in this "if(!empty($events) && ($events[0]['value'] == $row['value']))" only if there is at least 1 row.

P.S. you can change this function to this:

function event_initial_time($row,$show_unknown=0){
	$sql_cond=($show_unknown == 0)?' AND value<>2 ':'';

	$events = array();
	$res = DBselect('SELECT MAX(clock) as clock, value '.
					' FROM events '.
					' WHERE objectid='.$row['triggerid'].$sql_cond.
						' AND clock < '.$row['clock'].
						' AND object='.EVENT_OBJECT_TRIGGER.
					' GROUP BY value '.
					' ORDER BY clock DESC');
					
	while($rows = DBfetch($res)){
		$events[] = $rows;
	}
	if(!empty($events) && ($events[0]['value'] == $row['value'])){
		return false;
	}
	return true;
}