There are a number of tests that do not use bccomp to compare the ids used for multinode implementations. These fail and cause errors of varying degrees of usability.
1. Failure to select correct default value in combo boxes.
Here the last value in the list appears selected instead of the correct default since all options are 'selected' (see html generated).
In ccombobox.inc.php, the class CComboBox has a function AddItem that does the following test at line 93 (in version 1.4.4):
if($value == $this->value ...
Should be:
if(bccomp($value,$this->value) == 0 ...
2. Many screens don't return in 1.4.4
Calls to get_dbid (in db.in.php) don't return ie: stuck in endless loop.
Application spins deleting and adding rows ad finitum...
The following comparison (line 583) fails in similar fashion to problem 1 above.
if(($ret1 < $min) || ($ret1 >= $max)) {
Should be:
if((bccomp($ret1,$min)<0) || (bccomp($ret1,$max)>=0)) {
3. Cannot add more than one item to stacked graph
Line 222 in graphs.php
if( $new_gitem['itemid'] == $data['itemid'] &&
Should be
if( bccomp($new_gitem['itemid'],$data['itemid']) == 0 &&
4. Others ???
No doubt there are other such bugs, which no doubt have been fixed in the latest head(?) - haven't checked yet. Bugs logged in this thread to help others who experience these problems.
1. Failure to select correct default value in combo boxes.
Here the last value in the list appears selected instead of the correct default since all options are 'selected' (see html generated).
In ccombobox.inc.php, the class CComboBox has a function AddItem that does the following test at line 93 (in version 1.4.4):
if($value == $this->value ...
Should be:
if(bccomp($value,$this->value) == 0 ...
2. Many screens don't return in 1.4.4
Calls to get_dbid (in db.in.php) don't return ie: stuck in endless loop.
Application spins deleting and adding rows ad finitum...
The following comparison (line 583) fails in similar fashion to problem 1 above.
if(($ret1 < $min) || ($ret1 >= $max)) {
Should be:
if((bccomp($ret1,$min)<0) || (bccomp($ret1,$max)>=0)) {
3. Cannot add more than one item to stacked graph
Line 222 in graphs.php
if( $new_gitem['itemid'] == $data['itemid'] &&
Should be
if( bccomp($new_gitem['itemid'],$data['itemid']) == 0 &&
4. Others ???
No doubt there are other such bugs, which no doubt have been fixed in the latest head(?) - haven't checked yet. Bugs logged in this thread to help others who experience these problems.
Comment